This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add a limit option for autocomplete results #6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
May 12, 2021
germain-gg
force-pushed
the
gsouquet/limit-autocomplete-results
branch
from
b45ac88
to
7d8aa0f
Compare
t3chguy
reviewed
May 12, 2021
Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#17182
As @t3chguy mentioned, #5822 significantly increased the number of results returned by the
Autocompleter. There was no results pagination or limit meaning that every single match would be rendered in the list.Which took about 6 seconds when searching for
@min a room with 10k users on my laptopI have introduced a
limitparameter to thegetCompletionscall which will cap the number of results per provider to 20