Lots of room members can cause the browser to crash during autocomplete #6371

turt2live · 2018-03-21T18:11:12Z

for the devs: typing [at] in this room crashes Riot... as there seem to be a lot of names that the autocomplete tries to show and firefox refuses to render them all and kills the render process for me

https://matrix.to/#/!DgvjtOljKujDBrxyHk:matrix.org/$15216557001832JYKqi:matrix.ffslfl.net

turt2live · 2018-03-27T16:28:07Z

also affects chrome (as per #6394)

lukebarnard1 · 2018-04-24T12:26:36Z

Previously, we didn't autocomplete after 1 character for users (i.e. "@"). Now we do, it reveals how unperformant it is to render 15k things.

ara4n · 2018-04-26T12:49:17Z

Actually, is there a reason why we don't just cap the number of autocomplete things it tries to render at 100 or something?

lukebarnard1 · 2018-04-26T12:56:48Z

@ara4n we could also do this, absolutely

germain-gg · 2021-05-17T15:28:14Z

Closing as a cap for autocomplete has been added recently and that should very much alleviate this issue. View matrix-org/matrix-react-sdk#6016

* Sanitize untrusted variables from message previews before translation Fixes element-hq#18314 * Fix editing of `<sub>` & `<sup`> & `<u>` [\element-hq#6469](matrix-org/matrix-react-sdk#6469) Fixes element-hq#18211 * Zoom images in lightbox to where the cursor points [\element-hq#6418](matrix-org/matrix-react-sdk#6418) Fixes element-hq#17870 * Avoid hitting the settings store from TextForEvent [\element-hq#6205](matrix-org/matrix-react-sdk#6205) Fixes element-hq#17650 * Initial MSC3083 + MSC3244 support [\element-hq#6212](matrix-org/matrix-react-sdk#6212) Fixes element-hq#17686 and element-hq#17661 * Navigate to the first room with notifications when clicked on space notification dot [\element-hq#5974](matrix-org/matrix-react-sdk#5974) * Add matrix: to the list of permitted URL schemes [\element-hq#6388](matrix-org/matrix-react-sdk#6388) * Add "Copy Link" to room context menu [\element-hq#6374](matrix-org/matrix-react-sdk#6374) * 💭 Message bubble layout [\element-hq#6291](matrix-org/matrix-react-sdk#6291) Fixes element-hq#4635, element-hq#17773 element-hq#16220 and element-hq#7687 * Play only one audio file at a time [\#6417](matrix-org/matrix-react-sdk#6417) Fixes element-hq#17439 * Move download button for media to the action bar [\element-hq#6386](matrix-org/matrix-react-sdk#6386) Fixes element-hq#17943 * Improved display of one-to-one call history with summary boxes for each call [\element-hq#6121](matrix-org/matrix-react-sdk#6121) Fixes element-hq#16409 * Notification settings UI refresh [\element-hq#6352](matrix-org/matrix-react-sdk#6352) Fixes element-hq#17782 * Fix EventIndex double handling events and erroring [\element-hq#6385](matrix-org/matrix-react-sdk#6385) Fixes element-hq#18008 * Improve reply rendering [\element-hq#3553](matrix-org/matrix-react-sdk#3553) Fixes element-hq#9217, element-hq#7633, element-hq#7530, element-hq#7169, element-hq#7151, element-hq#6692 element-hq#6579 and element-hq#17440 * Improve performance of room name calculation [\element-hq#1801](matrix-org/matrix-js-sdk#1801) * Fix browser history getting stuck looping back to the same room [\element-hq#18053](element-hq#18053) * Fix space shortcuts on layouts with non-English keys in the places of numbers [\element-hq#17780](element-hq#17780) Fixes element-hq#17776 * Fix CreateRoomDialog exploding when making public room outside of a space [\element-hq#6493](matrix-org/matrix-react-sdk#6493) * Fix regression where registration would soft-crash on captcha [\element-hq#6505](matrix-org/matrix-react-sdk#6505) Fixes element-hq#18284 * only send join rule event if we have a join rule to put in it [\element-hq#6517](matrix-org/matrix-react-sdk#6517) * Improve the new download button's discoverability and interactions. [\element-hq#6510](matrix-org/matrix-react-sdk#6510) * Fix voice recording UI looking broken while microphone permissions are being requested. [\element-hq#6479](matrix-org/matrix-react-sdk#6479) Fixes element-hq#18223 * Match colors of room and user avatars in DMs [\element-hq#6393](matrix-org/matrix-react-sdk#6393) Fixes element-hq#2449 * Fix onPaste handler to work with copying files from Finder [\element-hq#5389](matrix-org/matrix-react-sdk#5389) Fixes element-hq#15536 and element-hq#16255 * Fix infinite pagination loop when offline [\element-hq#6478](matrix-org/matrix-react-sdk#6478) Fixes element-hq#18242 * Fix blurhash rounded corners missing regression [\element-hq#6467](matrix-org/matrix-react-sdk#6467) Fixes element-hq#18110 * Fix position of the space hierarchy spinner [\element-hq#6462](matrix-org/matrix-react-sdk#6462) Fixes element-hq#18182 * Fix display of image messages that lack thumbnails [\element-hq#6456](matrix-org/matrix-react-sdk#6456) Fixes element-hq#18175 * Fix crash with large audio files. [\element-hq#6436](matrix-org/matrix-react-sdk#6436) Fixes element-hq#18149 * Make diff colors in codeblocks more pleasant [\element-hq#6355](matrix-org/matrix-react-sdk#6355) Fixes element-hq#17939 * Show the correct audio file duration while loading the file. [\element-hq#6435](matrix-org/matrix-react-sdk#6435) Fixes element-hq#18160 * Fix various timeline settings not applying immediately. [\element-hq#6261](matrix-org/matrix-react-sdk#6261) Fixes element-hq#17748 * Fix issues with room list duplication [\element-hq#6391](matrix-org/matrix-react-sdk#6391) Fixes element-hq#14508 * Fix grecaptcha throwing useless error sometimes [\element-hq#6401](matrix-org/matrix-react-sdk#6401) Fixes element-hq#15142 * Update Emojibase and Twemoji and switch to IamCal (Slack-style) shortcodes [\element-hq#6347](matrix-org/matrix-react-sdk#6347) Fixes element-hq#13857 and element-hq#13334 * Respect compound emojis in default avatar initial generation [\element-hq#6397](matrix-org/matrix-react-sdk#6397) Fixes element-hq#18040 * Fix bug where the 'other homeserver' field in the server selection dialog would become briefly focus and then unfocus when clicked. [\element-hq#6394](matrix-org/matrix-react-sdk#6394) Fixes element-hq#18031 * Standardise spelling and casing of homeserver, identity server, and integration manager [\element-hq#6365](matrix-org/matrix-react-sdk#6365) * Fix widgets not receiving decrypted events when they have permission. [\element-hq#6371](matrix-org/matrix-react-sdk#6371) Fixes element-hq#17615 * Prevent client hangs when calculating blurhashes [\element-hq#6366](matrix-org/matrix-react-sdk#6366) Fixes element-hq#17945 * Exclude state events from widgets reading room events [\element-hq#6378](matrix-org/matrix-react-sdk#6378) * Cache feature_spaces\* flags to improve performance [\element-hq#6381](matrix-org/matrix-react-sdk#6381)

lampholder added T-Defect A-Performance Z-Platform-Specific P1 S-Critical Prevents work, causes data loss and/or has no workaround labels Mar 27, 2018

lampholder mentioned this issue Mar 27, 2018

Tab freezes/crashes trying to autocomplete in hq #6394

Closed

turt2live changed the title ~~Lots of room members can cause Firefox to crash during autocomplete~~ Lots of room members can cause the browser to crash during autocomplete Mar 27, 2018

MTRNord mentioned this issue Apr 21, 2018

Typing '@m' when in the composer in matrix HQ on develop locks chrome dead #6574

Closed

ara4n added X-Regression and removed Z-Platform-Specific labels Apr 21, 2018

lampholder added this to the RW008 - Candidates milestone Apr 24, 2018

lukebarnard1 mentioned this issue Apr 24, 2018

Don't autocomplete users for single "@" matrix-org/matrix-react-sdk#1848

Merged

ara4n closed this as completed Apr 26, 2018

ara4n reopened this Apr 26, 2018

ara4n added P2 A-Autocomplete and removed S-Critical Prevents work, causes data loss and/or has no workaround P1 X-Regression labels Apr 26, 2018

lampholder modified the milestones: RW008 - Candidates, Temporary Bug Bin Apr 30, 2018

germain-gg closed this as completed May 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lots of room members can cause the browser to crash during autocomplete #6371

Lots of room members can cause the browser to crash during autocomplete #6371

turt2live commented Mar 21, 2018

turt2live commented Mar 27, 2018

lukebarnard1 commented Apr 24, 2018

ara4n commented Apr 26, 2018

lukebarnard1 commented Apr 26, 2018

germain-gg commented May 17, 2021

Lots of room members can cause the browser to crash during autocomplete #6371

Lots of room members can cause the browser to crash during autocomplete #6371

Comments

turt2live commented Mar 21, 2018

turt2live commented Mar 27, 2018

lukebarnard1 commented Apr 24, 2018

ara4n commented Apr 26, 2018

lukebarnard1 commented Apr 26, 2018

germain-gg commented May 17, 2021