Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Enable sharing historical keys on invite #5839

Merged
merged 3 commits into from
Apr 9, 2021

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Apr 9, 2021

After discussion with Product, we're ready to enable this key sharing work from #5763 (based on matrix-org/matrix-spec-proposals#3061).

After discussion with Product, we're ready to enable this key sharing work from
#5763 (based on
matrix-org/matrix-spec-proposals#3061).
@jryans jryans requested a review from a team April 9, 2021 11:52
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the labs flag still serve a purpose of it's enabled by default? Do we plan to convert this to a real setting?

@jryans
Copy link
Collaborator Author

jryans commented Apr 9, 2021

Does the labs flag still serve a purpose of it's enabled by default? Do we plan to convert this to a real setting?

Hmm, no I don't see it becoming a setting... I think I am just conservative about removing flags at enablement time in case they need to be disabled later...

Anyway, in this case, it seems unlikely that we'd turn it back off... Instead, we'd just fix whatever the problem might be, so I'll remove the flag too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants