-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTUE: history visibility settings lie in E2E rooms #13349
Comments
Just hit this with a room on our homeserver. It seems RiotX handles this differently, as it shows the encrypted events before the invite (without a way to request keys from the senders (would that be even possible?)). Riot-web and desktop just don't show anything. Even non-encrypted previous events (before e2e was activated) are hidden. |
it has no way of knowing they exist, if riot-web/desktop see undecryptable events from before your join then they hide them for a better first time user experience |
To be a bit more precise (and to verify my own understanding), history starts at the point you were invited, not joined, right? |
Yes, my bad, assuming the right join rules; |
Unclear what we want done here, blindly hiding those settings seems wrong. Probably needs better copy for e2ee rooms? |
+1 on this issue, right now "Members only (since the point in time of selecting this option)" seems to actually work like "Members only (since they were invited)" in e2ee rooms. At the very least, I'd grey-out that option for e2ee rooms, but it would be fantastic if that was actually an functional option. |
In the duplicate issue #14889, @lampholder said:
|
This is even more confusing when you leave the room and then rejoin it. |
We have now enabled key sharing on invite, so I believe the visibility settings now make sense for E2EE rooms. |
@jryans the "Anyone" option still exists for E2E rooms which is a lie |
Maybe a new issue for that specifically might be better? |
given we can't see history from before you join an E2E room, the history visibility settings should not claim that you can.
The text was updated successfully, but these errors were encountered: