-
-
Notifications
You must be signed in to change notification settings - Fork 833
Add user preference to toggle call-related messages #4387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, just going to check with the product team to ensure this is something we still want in the app.
Co-Authored-By: Travis Ralston <[email protected]>
@turt2live or @t3chguy can you elaborate on what m.call messages this disables precisely pls to aid review? I can't discern too much from the spec. Feel free to DM on Matrix if that's easier. :) |
@nadonomy in a 1:1 call, it's all the timeline messages saying "TravisR accepted the call" and stuff like that. Some aren't shown because they are for protocol purposes only. Pulling the strings out the code, here's some examples:
... and various error states. Also I just found out how awful the translation support is in this area :( |
Looks like this PR might have gotten lost in the sea of PRs. Calls have changed quite a bit lately - is this something we still need? |
Hi, thank you for your contribution. After discussions with the product team, we decided that we would prefer to not add a setting to hide calls, so I will close this PR for now. As an output from these discussions, the Product team will be putting together guidance on decision making for adding new settings. |
Fixes element-hq/element-web#6841
Also adds a note about
invertedSettingsName
to the documentation on settings. (See initial code review comments for context.)Signed-off-by: Xinyue "Cheshire" Yang [email protected]