Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add user preference to toggle call-related messages #4387

Closed

Conversation

cheryllium
Copy link

@cheryllium cheryllium commented Apr 11, 2020

Fixes element-hq/element-web#6841

Also adds a note about invertedSettingsName to the documentation on settings. (See initial code review comments for context.)

Signed-off-by: Xinyue "Cheshire" Yang [email protected]

src/settings/Settings.js Outdated Show resolved Hide resolved
@cheryllium cheryllium changed the title [WIP] Add user preference to toggle call-related messages Add user preference to toggle call-related messages Apr 11, 2020
@t3chguy t3chguy requested a review from a team April 11, 2020 02:00
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, just going to check with the product team to ensure this is something we still want in the app.

src/shouldHideEvent.js Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from a team April 15, 2020 15:50
Co-Authored-By: Travis Ralston <[email protected]>
@nadonomy
Copy link
Contributor

@turt2live or @t3chguy can you elaborate on what m.call messages this disables precisely pls to aid review? I can't discern too much from the spec. Feel free to DM on Matrix if that's easier. :)

@turt2live
Copy link
Member

turt2live commented Apr 29, 2020

@nadonomy in a 1:1 call, it's all the timeline messages saying "TravisR accepted the call" and stuff like that. Some aren't shown because they are for protocol purposes only.

Pulling the strings out the code, here's some examples:

  • TravisR placed a voice call.
  • TravisR ended the call.
  • TravisR answered the call.

... and various error states.

Also I just found out how awful the translation support is in this area :(

@turt2live
Copy link
Member

Looks like this PR might have gotten lost in the sea of PRs. Calls have changed quite a bit lately - is this something we still need?

@kittykat
Copy link
Contributor

kittykat commented Apr 8, 2022

Hi, thank you for your contribution.

After discussions with the product team, we decided that we would prefer to not add a setting to hide calls, so I will close this PR for now.

As an output from these discussions, the Product team will be putting together guidance on decision making for adding new settings.

@kittykat kittykat closed this Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make an option to hide calls related messages
5 participants