Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an option to hide calls related messages #6841

Open
J316 opened this issue Jun 5, 2018 · 11 comments
Open

Make an option to hide calls related messages #6841

J316 opened this issue Jun 5, 2018 · 11 comments
Assignees
Labels
A-Timeline A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@J316
Copy link

J316 commented Jun 5, 2018

It would be useful to have an option to hide automatic messages showing when a call starts or ends or a recipient answers

@lampholder
Copy link
Member

I'm surprised this doesn't already exist along with the plethora of other automatic message visability options we have.

I'd like to rework those settings so they're less unweildy, but apart from that this seems like a good idea.

@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2018

+1 for rework :D

@35609902357
Copy link

Any news on this?

@t3chguy
Copy link
Member

t3chguy commented Apr 3, 2020

Nope otherwise they'd be here. This is a very nice thing for contributors as it is simple.

@cheryllium
Copy link
Contributor

I started a PR to add this option. I am not sure how to phrase it in the user interface, and the translator seems unable to process the text I chose. It shows up like this:

missing translation: en-us|Show messages about call information

Would appreciate any advice on better phrasing, as well as understanding why the translator failed and how that can be prevented.

@t3chguy
Copy link
Member

t3chguy commented Apr 11, 2020

Run the i18n yarn script.

@cheryllium
Copy link
Contributor

cheryllium commented Apr 11, 2020

@t3chguy Thank you, I got it. Are there other scripts I need to run? It's failing e2e tests and I don't think my code should be affecting that part of the app. Thanks again.

@keremgocen
Copy link

hey @cheryllium do you need any help?

@SimonBrandner
Copy link
Contributor

hey @cheryllium do you need any help?

They have already made a PR which passed the code review. It's currently waiting for the product team to take a look

@robintown
Copy link
Member

robintown commented Aug 4, 2021

@J316 The way call events appear in the timeline has been reworked to display them as event tiles, which automatically collapse together to save space and avoid showing a wall of call events. Do you feel this is still an issue?

@robintown robintown added the X-Needs-Info This issue is blocked awaiting information from the reporter label Aug 4, 2021
@J316
Copy link
Author

J316 commented Aug 6, 2021

@robintown Yes, it's still an issue. Tiles actually make the situation worse especially on mobile.

@SimonBrandner SimonBrandner removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Aug 6, 2021
@SimonBrandner SimonBrandner removed Easy Help Wanted Extra attention is needed labels Aug 26, 2021
@SimonBrandner SimonBrandner removed the Z-Community-PR Issue is solved by a community member's PR label Aug 27, 2021
@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P2 labels Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants