Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually construct query strings for browser-request instances #770

Merged
merged 5 commits into from
Oct 30, 2018

Conversation

turt2live
Copy link
Member

Because request just doesn't work for us in the browser, but browser-request is fine despite us having to do our own query strings.

Fixes element-hq/element-web#7620

Because `request` just doesn't work for us in the browser, but `browser-request` is fine despite us having to do our own query strings.

Fixes element-hq/element-web#7620
@turt2live turt2live requested a review from a team October 30, 2018 20:00
@turt2live
Copy link
Member Author

A proper solution would be element-hq/element-web#7634 however that is taking way too much time.

Copy link
Member

@ara4n ara4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@turt2live turt2live merged commit 62b2c07 into develop Oct 30, 2018
@turt2live turt2live deleted the travis/fix-request branch October 30, 2018 21:18
turt2live added a commit to element-hq/element-web that referenced this pull request Oct 31, 2018
This was introduced in matrix-org/matrix-react-sdk#2250 but can be pulled out due to matrix-org/matrix-js-sdk#770. See #7634 for more information about the future.
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this pull request Oct 31, 2018
This was introduced in #2250 but can be pulled out due to matrix-org/matrix-js-sdk#770. See element-hq/element-web#7634 for more information about the future.
turt2live added a commit that referenced this pull request Oct 31, 2018
This was introduced in matrix-org/matrix-react-sdk#2250 but can be pulled out due to #770. See element-hq/element-web#7634 for more information about the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants