Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from browser-request #7634

Closed
turt2live opened this issue Oct 30, 2018 · 1 comment
Closed

Migrate away from browser-request #7634

turt2live opened this issue Oct 30, 2018 · 1 comment
Labels
T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

It's ancient and not really maintainable as thing we should be using the future.

When migrating away, consider the nightmare that is #7620, which may require request/request#3053 (or similar). At the time of writing, there is an unknown piece of request (or its dependencies - browserified or otherwise) besides the one in the PR that is causing promises to freeze when dealing with request. This is assumed to be something preventing the callback being called, therefore preventing the promise from resolving.

@turt2live turt2live added the T-Task Tasks for the team like planning label Oct 30, 2018
turt2live added a commit that referenced this issue Oct 31, 2018
This was introduced in matrix-org/matrix-react-sdk#2250 but can be pulled out due to matrix-org/matrix-js-sdk#770. See #7634 for more information about the future.
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 31, 2018
This was introduced in #2250 but can be pulled out due to matrix-org/matrix-js-sdk#770. See element-hq/element-web#7634 for more information about the future.
turt2live added a commit to matrix-org/matrix-js-sdk that referenced this issue Oct 31, 2018
This was introduced in matrix-org/matrix-react-sdk#2250 but can be pulled out due to #770. See element-hq/element-web#7634 for more information about the future.
@t3chguy
Copy link
Member

t3chguy commented May 7, 2022

Closing in favour of matrix-org/matrix-js-sdk#801

@t3chguy t3chguy closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

2 participants