Revert "Update JS-DevTools/npm-publish action to v2 (#3336)"

[andybalaam]

Attempting to fix failure to publish to NPM due to an "invalid token" error https://github.com/matrix-org/matrix-js-sdk/actions/runs/4926808655/jobs/8819822367 .

This reverts commit ca9263f.

---

This change is marked as an internal change (Task), so will not be included in the changelog.

[t3chguy]

Indeed, due to the major update of npm-publish, the .npmrc file no longer contains the token after the run of the action

The user's ~/.npmrc file is no longer modified. Instead, a temporary .npmrc file is used. (JS-DevTools/npm-publish#15)

So the subsequent npm commands fail.

Regressed by #3336

[andybalaam]

So the subsequent npm commands fail.

Which subsequent npm commands? I only see one in this workflow.

[t3chguy]

@andybalaam

https://github.com/matrix-org/matrix-js-sdk/blob/develop/.github/workflows/release-npm.yml#L25-L31 runs npm publish, with v1 it first sets up the .npmrc file - with v2 it sets up a temporary one that gets thrown away

https://github.com/matrix-org/matrix-js-sdk/blob/develop/.github/workflows/release-npm.yml#L37 is the subsequent (not publish) npm command.

[andybalaam]

@t3chguy ah, thank you! I was not making the leap from release.yml to release-npm.yml

[t3chguy]

https://github.com/matrix-org/matrix-js-sdk/blob/develop/.github/workflows/release.yml#L38-L42 https://docs.github.com/en/actions/using-workflows/reusing-workflows

[andybalaam]

Feels like we should be able to specify multiple tags to npm-publish. I'll look at that if I have time.

[t3chguy]

That would be a nice modification, but the underlying npm publish command doesn't support it

[RiotRobot]

The backport to staging failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-staging staging
# Navigate to the new working tree
cd .worktrees/backport-staging
# Create a new branch
git switch --create backport-3350-to-staging
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73ca9c9ed28847454e13da358c581769e695ff42
# Push it to GitHub
git push --set-upstream origin backport-3350-to-staging
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-staging

Then, create a pull request where the base branch is staging and the compare/head branch is backport-3350-to-staging.