Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS-DevTools/npm-publish action to v2 #3336

Merged
merged 1 commit into from
May 2, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 2, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
JS-DevTools/npm-publish action major v1 -> v2

Release Notes

JS-DevTools/npm-publish

v2

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.


This change is marked as an internal change (Task), so will not be included in the changelog.

@renovate renovate bot requested a review from a team as a code owner May 2, 2023 11:06
@renovate renovate bot requested a review from andybalaam May 2, 2023 11:06
@renovate renovate bot added Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning labels May 2, 2023
@renovate renovate bot enabled auto-merge May 2, 2023 11:06
@renovate renovate bot added this pull request to the merge queue May 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2023
@andybalaam andybalaam added this pull request to the merge queue May 2, 2023
Merged via the queue into develop with commit ca9263f May 2, 2023
@andybalaam andybalaam deleted the renovate/js-devtools-npm-publish-2.x branch May 2, 2023 14:08
andybalaam added a commit that referenced this pull request May 10, 2023
andybalaam added a commit that referenced this pull request May 10, 2023
@andybalaam
Copy link
Contributor

This upgrade breaks release.yml workflow because inside release-npm.yml we run a second npm command after the npm-publish action, and expect the token to be still available, but in v2 it's not any more. See #3350 for more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant