-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for v2 of MSC3903 #3155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This is a deliberate breaking change on an unstable feature.
hughns
force-pushed
the
hughns/msc3903-v2
branch
from
February 14, 2023 18:27
f4d7a4b
to
0c24d65
Compare
florianduros
approved these changes
Feb 15, 2023
I will merge this on ~2023-02-28 after the iOS and Android releases on 2023-02-27. |
This is a deliberate breaking change on an unstable feature.
hughns
force-pushed
the
hughns/msc3903-v2
branch
from
March 2, 2023 08:45
23b5cd0
to
09aa549
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 2, 2023
Deprecates several experimental types
3 tasks
n.b. The code smells and duplication reported by SonarCloud will be rectified immediately by #3184 |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Mar 15, 2023
* Implement MSC3758: a push rule condition to match event properties exactly ([\matrix-org#3179](matrix-org#3179)). * Enable group calls without video and audio track by configuration of MatrixClient ([\matrix-org#3162](matrix-org#3162)). Contributed by @EnricoSchw. * Updates to protocol used for Sign in with QR code ([\matrix-org#3155](matrix-org#3155)). Contributed by @hughns. * Implement MSC3873 to handle escaped dots in push rule keys ([\matrix-org#3134](matrix-org#3134)). Fixes undefined/matrix-js-sdk#1454. * Fix spec compliance issue around encrypted `m.relates_to` ([\matrix-org#3178](matrix-org#3178)). * Fix reactions in threads sometimes causing stuck notifications ([\matrix-org#3146](matrix-org#3146)). Fixes element-hq/element-web#24000. Contributed by @justjanne.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a deliberate breaking change on an unstable feature.Needs to be merged at the same time as matrix-org/matrix-react-sdk#10165, and after the following mobile PRs are merged and in a release:
The releases of the above should happen on 2023-02-27 so this can be merged after that date.
This has now been rescoped so that it is a non-breaking change. It does introduce deprecations on experimental/unstable code that will be removed immediately by #3184
Checklist
Notes: Updates to protocol used for Sign in with QR code
Here's what your changelog entry will look like:
✨ Features