Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for v2 of MSC3903 #3155

Merged
merged 8 commits into from
Mar 2, 2023
Merged

Support for v2 of MSC3903 #3155

merged 8 commits into from
Mar 2, 2023

Conversation

hughns
Copy link
Member

@hughns hughns commented Feb 14, 2023

This is a deliberate breaking change on an unstable feature.

Needs to be merged at the same time as matrix-org/matrix-react-sdk#10165, and after the following mobile PRs are merged and in a release:

The releases of the above should happen on 2023-02-27 so this can be merged after that date.

This has now been rescoped so that it is a non-breaking change. It does introduce deprecations on experimental/unstable code that will be removed immediately by #3184

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Notes: Updates to protocol used for Sign in with QR code


Here's what your changelog entry will look like:

✨ Features

  • Updates to protocol used for Sign in with QR code (#3155). Contributed by @hughns.

This is a deliberate breaking change on an unstable feature.
@hughns hughns changed the title v2 of MSC3903 implementation Support for v2 of MSC3903 Feb 14, 2023
@hughns hughns marked this pull request as ready for review February 14, 2023 18:39
@hughns hughns requested a review from a team as a code owner February 14, 2023 18:39
@hughns
Copy link
Member Author

hughns commented Feb 16, 2023

I will merge this on ~2023-02-28 after the iOS and Android releases on 2023-02-27.

This is a deliberate breaking change on an unstable feature.
@hughns hughns added this pull request to the merge queue Mar 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 2, 2023
@hughns hughns added the T-Deprecation A pull request that makes something deprecated label Mar 2, 2023
@hughns hughns removed the T-Deprecation A pull request that makes something deprecated label Mar 2, 2023
@hughns
Copy link
Member Author

hughns commented Mar 2, 2023

n.b. The code smells and duplication reported by SonarCloud will be rectified immediately by #3184

@andybalaam andybalaam merged commit 4932030 into develop Mar 2, 2023
@andybalaam andybalaam deleted the hughns/msc3903-v2 branch March 2, 2023 13:15
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Mar 15, 2023
* Implement MSC3758: a push rule condition to match event properties exactly ([\matrix-org#3179](matrix-org#3179)).
* Enable group calls without video and audio track by configuration of MatrixClient ([\matrix-org#3162](matrix-org#3162)). Contributed by @EnricoSchw.
* Updates to protocol used for Sign in with QR code ([\matrix-org#3155](matrix-org#3155)). Contributed by @hughns.
* Implement MSC3873 to handle escaped dots in push rule keys ([\matrix-org#3134](matrix-org#3134)). Fixes undefined/matrix-js-sdk#1454.
* Fix spec compliance issue around encrypted `m.relates_to` ([\matrix-org#3178](matrix-org#3178)).
* Fix reactions in threads sometimes causing stuck notifications ([\matrix-org#3146](matrix-org#3146)). Fixes element-hq/element-web#24000. Contributed by @justjanne.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants