Support for v2 of MSC3903 #7372

hughns · 2023-02-14T17:36:19Z

Support for org.matrix.msc3903.rendezvous.v2.curve25519-aes-sha256 whilst maintaining compatibility with org.matrix.msc3903.rendezvous.v1.curve25519-aes-sha256
Improves the feedback in case of valid code but of unsupported algorithm or transport.
Added some test cases.
Fixed scenario where invalid QR would have led to app crashing.

Pull Request Checklist

I read the contributing guide
UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
Accessibility has been taken into account.

Pull request is based on the develop branch

Pull request contains a changelog file in ./changelog.d
You've made a self review of your PR
Pull request includes screenshots or videos of UI changes
Pull request includes a sign off

Signed-off-by: Hugh Nimmo-Smith [email protected]

codecov · 2023-02-14T18:29:53Z

Codecov Report

Base: 12.07% // Head: 12.11% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (c9dda44) compared to base (6c3131b).
Patch coverage: 71.73% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7372      +/-   ##
===========================================
+ Coverage    12.07%   12.11%   +0.04%     
===========================================
  Files         1638     1638              
  Lines       162005   162025      +20     
  Branches     66520    66529       +9     
===========================================
+ Hits         19557    19632      +75     
+ Misses      141802   141747      -55     
  Partials       646      646

Flag	Coverage Δ
uitests	`55.52% <100.00%> (+0.16%)`	⬆️
unittests	`5.97% <58.69%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ogin/Common/Service/MatrixSDK/QRLoginService.swift	`7.08% <0.00%> (-0.21%)`	⬇️
...RLogin/Common/Service/QRLoginServiceProtocol.swift	`0.00% <ø> (ø)`
Riot/Modules/Rendezvous/RendezvousService.swift	`77.77% <100.00%> (+1.30%)`	⬆️
...ailure/AuthenticationQRLoginFailureViewModel.swift	`61.70% <100.00%> (+2.61%)`	⬆️
.../MockAuthenticationQRLoginFailureScreenState.swift	`100.00% <100.00%> (ø)`
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift	`95.34% <0.00%> (-0.31%)`	⬇️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift	`82.77% <0.00%> (+7.65%)`	⬆️
...Modules/Room/Composer/View/FormattingToolbar.swift	`85.00% <0.00%> (+10.00%)`	⬆️
...I/Modules/Room/Composer/Model/ComposerModels.swift	`89.61% <0.00%> (+19.48%)`	⬆️
...odules/Room/PollHistory/View/SegmentedPicker.swift	`58.92% <0.00%> (+22.26%)`	⬆️