Simplify user verification state #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/user_trust
branch
2 times, most recently
from
aed6ee7
to
1635415
Compare
Anderas
force-pushed
the
andy/user_trust
branch
from
1635415
to
3fef185
Compare
Anderas
requested review from
a team and
Velin92
and removed request for
a team
Anderas
force-pushed
the
andy/user_trust
branch
from
b29001d
to
1dafa92
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1740 +/- ##
===========================================
+ Coverage 37.75% 37.78% +0.02%
===========================================
Files 615 616 +1
Lines 96889 96899 +10
Branches 41856 41867 +11
===========================================
+ Hits 36580 36610 +30
+ Misses 59261 59242 -19
+ Partials 1048 1047 -1
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/matrix-org/internal-config/issues/1325
The SDK has previously relied on
MXUserTrustLevelto determine whether any particular user is verified or not. It did so by distinguishing between "local" and "cross-signed" trust, where a user is considered verified if either one of those fields is true. This is however unnecessarily complex model, not used upcoming rust-crypto, and does not really make sense, given that "user verification" should only be possible via cross-signing, not by setting manual values.To improve this, remove
MXUserTrustLevelentirely and replace it with a simpleisVerifiedboolean. This makes the API everywhere much simpler to use. As a downside, we have to deal with some amount of migration from the previous model (we use NSCoding to persist these values). To ensure correct migration, we will now store "version" property in MXCrossSigningInfo, which is used to decode the values correctlyAdditionally replace
NSProgresswithMXTrustSummarywhen computingtrustSummaryfor more than one user or device. UsingNSProgresshas worked okay, but it makes for some strange and clunky API (e.g..fractionCompleted >= 0instead ofallAreTrusted).