Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor user / room encryption trust level #7430

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Mar 16, 2023

Resolves https://github.com/matrix-org/internal-config/issues/1325

Related SDK change matrix-org/matrix-ios-sdk#1740

Conform to latest SDK and extract out user and room encryption state computation into a separate class to be easily testable.

@Anderas Anderas changed the title Refactor encryption trust level Refactor user / room encryption trust level Mar 16, 2023
@Anderas Anderas force-pushed the andy/user_trust branch 2 times, most recently from 11d1d1d to 51b4e17 Compare March 16, 2023 13:25
@Anderas Anderas requested review from a team and aringenbach and removed request for a team March 16, 2023 13:26
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 61.76% and project coverage change: +0.01 🎉

Comparison is base (31de127) 12.13% compared to head (5c669a7) 12.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7430      +/-   ##
===========================================
+ Coverage    12.13%   12.15%   +0.01%     
===========================================
  Files         1643     1644       +1     
  Lines       162532   162524       -8     
  Branches     66735    66728       -7     
===========================================
+ Hits         19730    19754      +24     
+ Misses      142157   142125      -32     
  Partials       645      645              
Flag Coverage Δ
uitests 55.23% <ø> (ø)
unittests 6.02% <61.76%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Categories/MXRoom+Riot.m 0.00% <0.00%> (ø)
Riot/Categories/MXRoomSummary+Riot.m 0.00% <0.00%> (ø)
...les/Encryption/EncryptionInfo/EncryptionInfoView.m 0.00% <ø> (ø)
...ryption/EncryptionTrustLevelBadgeImageHelper.swift 0.00% <ø> (ø)
...les/MatrixKit/Models/Room/MXKRoomBubbleComponent.m 29.45% <0.00%> (ø)
...ogin/Common/Service/MatrixSDK/QRLoginService.swift 7.08% <0.00%> (ø)
Riot/Modules/Encryption/EncryptionTrustLevel.swift 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anderas Anderas merged commit 7f5d3b4 into develop Mar 20, 2023
@Anderas Anderas deleted the andy/user_trust branch March 20, 2023 12:52
Anderas added a commit that referenced this pull request Mar 22, 2023
This reverts commit 7f5d3b4, reversing
changes made to 5a3adde.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants