-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Edited messages appear twice in fulltext search #3363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3363 +/- ##
==========================================
- Coverage 67.44% 67.43% -0.02%
==========================================
Files 521 521
Lines 47366 47378 +12
==========================================
+ Hits 31946 31948 +2
- Misses 11422 11429 +7
- Partials 3998 4001 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for this! |
As stated in #3358 the search response contains both original and edited message.
This PR fixes it by removing of the original message from the fulltext index after indexing the edit message event.
I also made some cosmetic changes/fixes i found in the code
Signed-off-by:
Alexander Dubovikov <[email protected]>