Edited messages appear twice in fulltext search

[S7evinK]

When a message is edited, they appear twice in the results of /search.
While Element Web seems to aggregate the results and only returns one results, Element Android returns both. This may be a bit confusing.

IMO, Dendrite should only return the latest message.

The responsible code for this:

dendrite/syncapi/consumers/roomserver.go

Lines 593 to 627 in 14a6c10

	func (s *OutputRoomEventConsumer) writeFTS(ev *rstypes.HeaderedEvent, pduPosition types.StreamPosition) error {
	if !s.cfg.Fulltext.Enabled {
	return nil
	}
	e := fulltext.IndexElement{
	EventID: ev.EventID(),
	RoomID: ev.RoomID().String(),
	StreamPosition: int64(pduPosition),
	}
	e.SetContentType(ev.Type())
	switch ev.Type() {
	case "m.room.message":
	e.Content = gjson.GetBytes(ev.Content(), "body").String()
	case spec.MRoomName:
	e.Content = gjson.GetBytes(ev.Content(), "name").String()
	case spec.MRoomTopic:
	e.Content = gjson.GetBytes(ev.Content(), "topic").String()
	case spec.MRoomRedaction:
	log.Tracef("Redacting event: %s", ev.Redacts())
	if err := s.fts.Delete(ev.Redacts()); err != nil {
	return fmt.Errorf("failed to delete entry from fulltext index: %w", err)
	}
	return nil
	default:
	return nil
	}
	if e.Content != "" {
	log.Tracef("Indexing element: %+v", e)
	if err := s.fts.Index(e); err != nil {
	return err
	}
	}
	return nil
	}

We'd need to check if m.relates.to in content contains a rel_type of m.replace and then delete the event_id from the fulltext index before indexing the new event.

[adnull]

Hi! I'd like to take this.

[S7evinK]

Sure, go for it! :)

[S7evinK]

Fixed with #3363.