Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide links on tracking code page and no data email #18218

Merged
merged 5 commits into from
Oct 28, 2021

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Oct 25, 2021

Description:

Fixes #15429
Added setup guide links for Wordpress, Squarespace, Wix, SharePoint, Joomla, Shopify and Google Tag Manager to the 'No data' email and to the tracking code page.

Review

@bx80 bx80 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 25, 2021
@bx80 bx80 added this to the 4.6.0 milestone Oct 25, 2021
@bx80 bx80 self-assigned this Oct 25, 2021
@sgiehl
Copy link
Member

sgiehl commented Oct 26, 2021

@tsteur @Findus23 Not sure on that one, but do we still need to add rel="noreferrer noopener" to new links, or is that meanwhile covered by meta tags or headers?

@tsteur
Copy link
Member

tsteur commented Oct 27, 2021

noreferrer we wouldn't need anymore AFAIK. noopener is used by default in FF 79 https://bugzilla.mozilla.org/show_bug.cgi?id=1522083 , safari 68 https://webkit.org/blog/8475/release-notes-for-safari-technology-preview-68/ brave: brave/brave-browser#1840

Here's a detailed list of supported browsers: https://caniuse.com/mdn-html_elements_area_implicit_noopener

Seems maybe opera and android browser doesn't have this fixed yet and maybe still need it for a while? Also samsung browser only seems to have it since recently etc.

@bx80 bx80 added the Needs Review PRs that need a code review label Oct 27, 2021
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sgiehl sgiehl merged commit e6ad78b into 4.x-dev Oct 28, 2021
@sgiehl sgiehl deleted the m15429-add-guide-links branch October 28, 2021 06:26
@craigvc
Copy link

craigvc commented Mar 1, 2023

How does this get dealt with by white label plugin - i would like to reference my own guides.

@bx80
Copy link
Contributor Author

bx80 commented Mar 2, 2023

Thanks for the question @craigvc, I haven't tested these links specifically with the white label plugin, but my understanding is that any links to matomo.org should be automatically removed. Unfortunately there isn't any capability to add your own links at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
4 participants