-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target=_blank now should default to rel=noopener #1840
Comments
cc: @tomlowenthal can we get prioritization on this one and put in the right milestone, otherwise 1.x Backlog is fine. |
I think 1.x is right. If someone on the sec team wants to implement sooner that that, it can ride the trains up earlier. |
I'm interested in this issue, if someone specifies how exactly the final algorithm should look like, I will be happy to implement it myself. The following is how I understand this, please correct me if I'm wrong. I'll have to do some testing with all 3 browsers (Safari, Mozilla, Chrome) to see how they behave right now and what's in previews/behind flags. Also, may be, the Chromium itself is a better place for resolving this, e.g. behind a flag and just setting that flag for Brave during compilation? First of all, this issue mirrors whatwg#4078 and Bugzilla#1503681, which is only only about anchors Here is the tentative summary (please correct me if I'm wrong):
[1] WebKit plan https://trac.webkit.org/changeset/237144/webkit/ Note that [2] conflicts with comment [3] (just a comment) [4] whatwg/html#4078 (comment) Edit: grammar. |
See also: Chromium Issue 898942 |
bumping to p3 because there are a lot of instances in brave-core where we use target=_blank |
This has landed in Chrome 88: https://bugs.chromium.org/p/chromium/issues/detail?id=898942#c29 |
https://webkit.org/blog/8475/release-notes-for-safari-technology-preview-68/
The text was updated successfully, but these errors were encountered: