Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives on Iron browser for Iron-model devices. #7557

Merged
merged 2 commits into from
Jan 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Tests/fixtures/smartphone-24.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9023,10 +9023,10 @@
platform: ""
client:
type: browser
name: Iron
version: ""
engine: WebKit
engine_version: "537.36"
name: Chrome Mobile
version: "91.0.4472.120"
engine: Blink
engine_version: "91.0.4472.120"
device:
type: smartphone
brand: Hammer
Expand Down
4 changes: 2 additions & 2 deletions Tests/fixtures/smartphone-32.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6829,7 +6829,7 @@
platform: ""
client:
type: browser
name: Iron
name: Android Browser
version: ""
engine: WebKit
engine_version: "534.30"
Expand All @@ -6838,7 +6838,7 @@
brand: Hammer
model: Iron
os_family: Android
browser_family: Chrome
browser_family: Android Browser
-
user_agent: Mozilla/5.0 (Linux; Android 11; V2180A) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.5112.105 Mobile Safari/537.36
os:
Expand Down
8 changes: 4 additions & 4 deletions Tests/fixtures/smartphone-7.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4863,10 +4863,10 @@
platform: ""
client:
type: browser
name: Iron
version: ""
engine: WebKit
engine_version: "537.36"
name: Chrome Mobile
version: "77.0.3865.116"
engine: Blink
engine_version: "77.0.3865.116"
device:
type: smartphone
brand: Jinga
Expand Down
8 changes: 4 additions & 4 deletions Tests/fixtures/smartphone-9.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8913,10 +8913,10 @@
platform: ""
client:
type: browser
name: Iron
version: ""
engine: WebKit
engine_version: "537.36"
name: Chrome Mobile
version: "75.0.3770.101"
engine: Blink
engine_version: "75.0.3770.101"
device:
type: smartphone
brand: Hammer
Expand Down
2 changes: 1 addition & 1 deletion regexes/client/browsers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1868,7 +1868,7 @@
versions:
28: 'Blink'

- regex: 'Iron(?:/(\d+[\.\d]+))?'
- regex: 'Iron/(\d+[\.\d]+)'
name: 'Iron'
version: '$1'
engine:
Expand Down
Loading