Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives on Iron browser for Iron-model devices. #7557

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

JBYoshi
Copy link
Contributor

@JBYoshi JBYoshi commented Jan 20, 2024

Description:

Devices with "Iron" in their brand names were originally being incorrectly detected as running the Iron browser. This PR makes one of the two Iron browser regexes more strict to avoid those false positives.

The two regexes now check for either the "Chrome/" token followed by an "Iron" token or for an "Iron/" token, with the slash. There are existing test cases covering both of those cases (Chrome/ Iron case, Iron/ case). I cross-checked the patterns with https://user-agents.net/download?browser_type=browser&browser=iron to make sure there weren't any other patterns used by the Iron browser.

Review

@sanchezzzhak sanchezzzhak enabled auto-merge (squash) January 22, 2024 09:12
@sanchezzzhak sanchezzzhak merged commit aad5786 into matomo-org:master Jan 22, 2024
15 checks passed
@JBYoshi JBYoshi deleted the iron branch January 23, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants