-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbolic comparisions #998
Conversation
It looks nicer, but we need to be careful with how numbers and certain mathics structures handled different in sympy are compared. |
Thanks. And yes, I'm working on that. |
It looks like all the tests have passed. Maybe we can add a few more tests? |
Great! It would be nice to have more tests if you can think a couple.
Regarding the message, you can implement it as an exception, raise it from do_cmp, capture in the different builtins, and raise the message from there. |
We see a failure in pymathics classes that subclass AtomicBuiltin(). In particular, the upcoming `pymathics.graph`.
Thanks! I'll look into that. |
@weakit Great work! |
Closes #956