Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic comparisions #998

Closed
wants to merge 7 commits into from
Closed

Conversation

weakit
Copy link
Contributor

@weakit weakit commented Nov 5, 2020

Closes #956

@mmatera
Copy link
Contributor

mmatera commented Nov 5, 2020

It looks nicer, but we need to be careful with how numbers and certain mathics structures handled different in sympy are compared.

@weakit
Copy link
Contributor Author

weakit commented Nov 5, 2020

It looks nicer, but we need to be careful with how numbers and certain mathics structures handled different in sympy are compared.

Thanks. And yes, I'm working on that.

@weakit
Copy link
Contributor Author

weakit commented Nov 5, 2020

It looks like all the tests have passed. Maybe we can add a few more tests?
And also could someone help me implement the General::nord message? (for when complex numbers are compared)

@mmatera
Copy link
Contributor

mmatera commented Nov 5, 2020

It looks like all the tests have passed. Maybe we can add a few more tests?

Great! It would be nice to have more tests if you can think a couple.

And also could someone help me implement the General::nord message? (for when complex numbers are compared)

Regarding the message, you can implement it as an exception, raise it from do_cmp, capture in the different builtins, and raise the message from there.

We see a failure in pymathics classes that subclass AtomicBuiltin().

In particular, the upcoming `pymathics.graph`.
@weakit
Copy link
Contributor Author

weakit commented Nov 6, 2020

Regarding the message, you can implement it as an exception, raise it from do_cmp, capture in the different builtins, and raise the message from there.

Thanks! I'll look into that.

@GarkGarcia
Copy link
Contributor

@weakit Great work!

@weakit weakit closed this Nov 7, 2020
@weakit weakit mentioned this pull request Nov 7, 2020
@weakit weakit deleted the symbolic-minmax branch November 7, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbolic Min/Max
4 participants