Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic Min/Max #956

Closed
weakit opened this issue Oct 11, 2020 · 3 comments · Fixed by #1000
Closed

Symbolic Min/Max #956

weakit opened this issue Oct 11, 2020 · 3 comments · Fixed by #1000

Comments

@weakit
Copy link
Contributor

weakit commented Oct 11, 2020

Min[E, Pi] currently does not give a result.

This is what Wolfram gives:

image

sympy has inbuilt Min/Max functions that have the same functionality:

>>> Min(E, pi)
E

One thing to note tho is that sympy's min/max is pretty slow with large (>1000 element) lists. See sympy/sympy#16249.

@rocky
Copy link
Member

rocky commented Oct 11, 2020

You can find classes Min, Max and the internal class used _MinMax here.

Although crude, all I did was run grep -r 'class Min(' from the top-level directory.

If you can fix and put in a PR that'd be awesome.

@weakit
Copy link
Contributor Author

weakit commented Oct 11, 2020

It was stupid, but since at the time I didn't have the source code, I tried searching through the code on GitHub. Searching for Min or Max didn't give me a good hit.

GitHub search isn't reliable I guess lol

I'll see what I can do.

@mmatera
Copy link
Contributor

mmatera commented Oct 17, 2020

Implemented at PR #982

This was referenced Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants