Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg namespacing #3799

Merged
merged 13 commits into from
Aug 30, 2024
Merged

Reorg namespacing #3799

merged 13 commits into from
Aug 30, 2024

Conversation

mathemancer
Copy link
Contributor

Fixes #3797

This PR reorganizes and cleans up some of the RPC function code and naming.

Technical details

The PR makes the renaming changes in the issue, and also:

  • removes an unneeded parameter from list_db_priv (no effect on API)
  • Modifies the response a bit from databases.get (previously database_privileges.get_self to conform with what one would expect from such a function. The information is a superset of what was previously returned.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer
Copy link
Contributor Author

@Anish9901 Please go through this one a bit carefully, since there were so many renamings.

@pavish This is ready to wire up with the front end.

@mathemancer mathemancer added pr-status: review A PR awaiting review pr-status: revision A PR awaiting follow-up work from its author after review labels Aug 29, 2024
@mathemancer mathemancer added this to the Beta milestone Aug 29, 2024
@mathemancer mathemancer removed the request for review from pavish August 29, 2024 08:51
@mathemancer
Copy link
Contributor Author

@Anish9901 This is ready for backend review, but I'm marking it as 'draft' since @pavish plans to make the front end changes in this same PR.

@mathemancer mathemancer marked this pull request as draft August 29, 2024 08:52
@pavish pavish marked this pull request as ready for review August 29, 2024 13:04
@pavish
Copy link
Member

pavish commented Aug 29, 2024

I've wired up the frontend with the changes.

@pavish pavish removed their assignment Aug 29, 2024
@pavish pavish removed the pr-status: revision A PR awaiting follow-up work from its author after review label Aug 29, 2024
Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Anish9901 Anish9901 added this pull request to the merge queue Aug 30, 2024
Merged via the queue into develop with commit e622d7e Aug 30, 2024
37 checks passed
@Anish9901 Anish9901 deleted the reorg_namespacing branch August 30, 2024 12:32
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize RPC function namespacing
4 participants