Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize RPC function namespacing #3797

Closed
mathemancer opened this issue Aug 28, 2024 · 0 comments · Fixed by #3799
Closed

Reorganize RPC function namespacing #3797

mathemancer opened this issue Aug 28, 2024 · 0 comments · Fixed by #3799
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue work: backend Related to Python, Django, and simple SQL

Comments

@mathemancer
Copy link
Contributor

mathemancer commented Aug 28, 2024

Problem

The namespacing of our RPC functions has already become a bit inconsistent, and sometimes misleading.

Proposed solution

Make the following changes:

old new
database_privileges.list_direct databases.privileges.list_direct
database_privileges.replace_for_roles databases.privileges.replace_for_roles
database_privileges.get_self databases.get
database_setup.create_new databases.setup.create_new
database_setup.connect_existing databases.setup.connect_existing
databases.list databases.configured.list
configured_roles.add roles.configured.add
configured_roles.delete roles.configured.delete
configured_roles.list roles.configured.list
configured_roles.set_password roles.configured.set_password
schema_privileges.list_direct schemas.privileges.list_direct
schema_privileges.replace_for_roles schemas.privileges.replace_for_roles
servers.list servers.configured.list
table_privileges.list_direct tables.privileges.list_direct
table_privileges.replace_for_roles tables.privileges.replace_for_roles

Additional context

This arose from much confusion around database_privileges.get_self, and noticing that it was getting hard to find some functionality in the current state.

I don't expect this to take more than an hour, but I need to time it when it won't disrupt other work.

@mathemancer mathemancer added type: enhancement needs: triage This issue has not yet been reviewed by a maintainer labels Aug 28, 2024
@seancolsen seancolsen added this to the Beta milestone Aug 28, 2024
@seancolsen seancolsen added work: backend Related to Python, Django, and simple SQL ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue and removed needs: triage This issue has not yet been reviewed by a maintainer labels Aug 28, 2024
@mathemancer mathemancer mentioned this issue Aug 29, 2024
7 tasks
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue work: backend Related to Python, Django, and simple SQL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants