Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First steps of RPC implementation for table page #3704

Merged
merged 10 commits into from
Aug 1, 2024
Merged

First steps of RPC implementation for table page #3704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d3ad0cc
Transition frontend to use RPC API for columns.list
seancolsen Jul 30, 2024
e490df7
Transition frontend to use RPC API for constraints.list
seancolsen Jul 30, 2024
32f8441
Migrate types for RPC-based joinable_tables API
seancolsen Jul 30, 2024
7329902
Remove unused `base` property from JoinableTable
seancolsen Jul 30, 2024
a6b9695
Transition frontend to use RPC API for records.list
seancolsen Jul 30, 2024
010f5c5
Fix renamed records request params
seancolsen Jul 30, 2024
2ca5852
Update code comments
seancolsen Jul 30, 2024
e0d29e0
Fix code comment
seancolsen Jul 31, 2024
f8c3b5d
Merge branch 'develop' into table_page_rpc
seancolsen Aug 1, 2024
b42b000
Merge branch 'develop' into table_page_rpc
pavish Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions mathesar_ui/src/api/rest/columns.ts
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions mathesar_ui/src/api/rest/types/queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Column } from '@mathesar/api/rest/types/tables/columns';
import type { JpPath } from '@mathesar/api/rest/types/tables/joinable_tables';
import type { PaginatedResponse } from '@mathesar/api/rest/utils/requestUtils';
import type { Column } from '@mathesar/api/rpc/columns';
import type { Schema } from '@mathesar/api/rpc/schemas';
import type { JoinPath } from '@mathesar/api/rpc/tables';

export type QueryColumnAlias = string;

Expand All @@ -12,7 +12,7 @@ export type QueryColumnAlias = string;
export interface QueryInstanceInitialColumn {
alias: QueryColumnAlias;
id: Column['id'];
jp_path?: JpPath;
jp_path?: JoinPath;
}

// TODO: Extend this to support more complicated filters
Expand Down
162 changes: 0 additions & 162 deletions mathesar_ui/src/api/rest/types/tables/columns.ts
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions mathesar_ui/src/api/rest/types/tables/constraints.ts
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions mathesar_ui/src/api/rest/types/tables/joinable_tables.ts
View file
Open in desktop

This file was deleted.

Loading
Loading