Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First steps of RPC implementation for table page #3704

Merged
merged 10 commits into from
Aug 1, 2024
Merged

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Jul 24, 2024

This PR is the first of many PRs that will move the table page from REST API calls to RPC API calls.

It handles:

  • columns.list
  • constraints.list
  • records.list
    • (basic)
    • With sorting
    • With limit
    • With offset

It doesn't handle:

  • tables.list_joinable
  • records.list
    • With filtering
    • With grouping
    • With record summaries
  • Any DDL
  • Any DML

Already I can spot some issues, such as:

  • extra requests when loading
  • strange loading spinner behavior

There are probably loads of other issues and bugs as well. But I'd like to do more thorough QA and polish later. For now I want to get this in and continue with the broad strokes so that we can better distribute and prioritize polish tasks later.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added this to the Beta milestone Jul 24, 2024
@seancolsen seancolsen changed the base branch from develop to tables_rpc_fe July 24, 2024 02:28
Base automatically changed from tables_rpc_fe to develop July 25, 2024 23:10
@seancolsen seancolsen changed the title Table page RPC front end First steps of RPC implementation for table page Jul 30, 2024
@seancolsen seancolsen marked this pull request as ready for review July 30, 2024 18:39
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Jul 30, 2024
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seancolsen I've looked through the code and it looks good. I have not QA tested the changes thoroughly, as you've mentioned that there are bugs in the description.

The api/ui/v0/connections/<id>/types/ endpoint is not working anymore (it works if id=1, but not for other values) and the frontend isn't using the newly implemented types rpc endpoint yet. This is causing the data type of columns to be unknown. This is expected, I'm mentioning it here assuming it might help you prioritize items.

Comment on lines +29 to +36

// TODO_BETA
//
// We need to find another way to get the valid target types for a column
// since the RPC API no longer returns this.

// column.valid_target_types ?? [],
[],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue created to keep track of this?

Comment on lines +129 to +135
// TODO_BETA Do we need shareConsumer here? Previously we had been
// passing:
//
// ```
// ...this.shareConsumer?.getQueryParams()
// ```
this.promise = api.constraints.list(this.apiContext).run();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will depend on the changes have to make for publicly shared links. The consumer here provides a shared-link-uuid query param which used to get validated for each request made to any publicly shared table (& it's related APIs).

@pavish pavish added this pull request to the merge queue Aug 1, 2024
Merged via the queue into develop with commit 0c81a08 Aug 1, 2024
35 checks passed
@pavish pavish deleted the table_page_rpc branch August 1, 2024 14:02
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants