Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with tables.patch RPC method #3699

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Fix issues with tables.patch RPC method #3699

merged 4 commits into from
Jul 22, 2024

Conversation

seancolsen
Copy link
Contributor

When implementing the front end for patching tables, I encountered the following issues with tables.patch:

  • All requests were failing with:

    ProgrammingError: cannot adapt type 'dict' us ing placeholder '%s' (format: AUTO)

    ecc9cde fixes this.

  • I was unable to submit a request to rename a table to its current name.

    da89d22 fixes this.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @seancolsen, We could also drop __msar.rename_table as that would be deprecated, I'll leave it up to you to decide whether you want to make that change.

@seancolsen seancolsen added this pull request to the merge queue Jul 22, 2024
@seancolsen
Copy link
Contributor Author

I've not been bothering to drop any deprecated functions. My understanding is that there are already loads of such functions that we've never bothered to drop.

Merged via the queue into develop with commit 3a9e51c Jul 22, 2024
36 checks passed
@seancolsen seancolsen deleted the tables_patch branch July 22, 2024 17:36
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants