Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL syntax highlighting in VS Code for SQL tests #3588

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix SQL syntax highlighting in VS Code for SQL tests #3588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db/sql/test_0_msar.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1378,7 +1378,7 @@ $f$ LANGUAGE plpgsql;

CREATE OR REPLACE FUNCTION test_add_mathesar_table_badname() RETURNS SETOF TEXT AS $f$
DECLARE
badname text := $b$M"new"'dsf' \t"$b$;
badname text := '"new"''dsf'' \t"';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue: This isn't the same string. Regardless, it still tests the same thing. I just don't like having to think while reviewing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M"new"'dsf' \t"

vs

"new"'dsf' \t"

Looks like I accidentally removed that M — sorry about that! My intent was to preserve the content of the string. This must have been a typo or something. Whoops.

BEGIN
PERFORM msar.add_mathesar_table(
'tab_create_schema'::regnamespace::oid, badname, null, null, null
Expand Down
Loading