Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL syntax highlighting in VS Code for SQL tests #3588

Merged
merged 1 commit into from
May 20, 2024

Conversation

seancolsen
Copy link
Contributor

As discussed in our DB-layer meeting.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

This fixes syntax highlighting in VS Code
@seancolsen seancolsen added this to the Beta milestone May 14, 2024
@seancolsen seancolsen added the pr-status: review A PR awaiting review label May 14, 2024
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, if it makes the VSCode folks happy, I'm happy.

@@ -1378,7 +1378,7 @@ $f$ LANGUAGE plpgsql;

CREATE OR REPLACE FUNCTION test_add_mathesar_table_badname() RETURNS SETOF TEXT AS $f$
DECLARE
badname text := $b$M"new"'dsf' \t"$b$;
badname text := '"new"''dsf'' \t"';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue: This isn't the same string. Regardless, it still tests the same thing. I just don't like having to think while reviewing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M"new"'dsf' \t"

vs

"new"'dsf' \t"

Looks like I accidentally removed that M — sorry about that! My intent was to preserve the content of the string. This must have been a typo or something. Whoops.

@mathemancer
Copy link
Contributor

I think it's appropriate to merge this into develop (as you set up) and then merge that into the architectural_overhaul branch.

@mathemancer mathemancer added this pull request to the merge queue May 20, 2024
Merged via the queue into develop with commit 5bbcbbc May 20, 2024
33 checks passed
@mathemancer mathemancer deleted the sql_syntax_highlighting_quotes branch May 20, 2024 06:54
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants