Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Catalog][BottomAppBar][BottomSheet][NavigationDrawer][SearchView][SideSheet][Predictive Back] state mismatch between bottom sheet and back callback after restarting activity #3575

Closed
manabu-nakamura opened this issue Sep 14, 2023 · 1 comment
Closed

[Catalog][BottomAppBar][BottomSheet][NavigationDrawer][SearchView][SideSheet][Predictive Back] state mismatch between bottom sheet and back callback after restarting activity #3575

manabu-nakamura opened this issue Sep 14, 2023 · 1 comment
Assignees
@dsn5ft
Labels
bug

Comments

@manabu-nakamura
Copy link
Contributor

manabu-nakamura commented Sep 14, 2023 •
edited
Loading

Description: The expanded bottom sheet is still expanded after restarting the activity (e.g. after rotating the device). But, the back callback is disabled and the bottom sheet will not detach from the left and right edges of the screen.
https://m3.material.io/components/bottom-sheets/guidelines#3d7735e2-73ea-4f3e-bd42-e70161fc1085

Similar things are happening in other demos (BottomSheetMainDemoFragment, NavigationDrawerDemoActivity, CustomNavigationDrawerDemoActivity, SearchMainDemoActivity, SearchRecyclerDemoActivity, and SideSheetMainDemoFragment) as well.

(before restarting activity)
Screenshot_20230913_171952
(after restarting activity)
Screenshot_20230913_172001

Expected behavior: The expanded bottom sheet is hidden or the back callback is enabled after restarting the activity (e.g. after rotating the device).

Minimal sample app repro: Catalog app

Android API version: 34

Material Library version: 1.11.0-alpha02

Device: Emulator 32.1.15 (API 34)
@manabu-nakamura manabu-nakamura mentioned this issue Sep 14, 2023
Closed
@dsn5ft dsn5ft self-assigned this Sep 14, 2023
@manabu-nakamura manabu-nakamura changed the title [Catalog][BottomAppBar][BottomSheet][Predictive Back] state mismatch between bottom sheet and back callback after restarting activity [Catalog][BottomAppBar][BottomSheet][NavigationDrawer][SideSheet][Predictive Back] state mismatch between bottom sheet and back callback after restarting activity Sep 18, 2023
@manabu-nakamura manabu-nakamura changed the title [Catalog][BottomAppBar][BottomSheet][NavigationDrawer][SideSheet][Predictive Back] state mismatch between bottom sheet and back callback after restarting activity [Catalog][BottomAppBar][BottomSheet][NavigationDrawer][SearchView][SideSheet][Predictive Back] state mismatch between bottom sheet and back callback after restarting activity Sep 19, 2023
@dsn5ft dsn5ft closed this as completed in f9102c7 Sep 19, 2023
dsn5ft added a commit that referenced this issue Sep 19, 2023
@dsn5ft
[Catalog][Predictive Back][Side Sheet] Update side sheet state handli…
357cf2d 
…ng to be more accurate in demos

Fixes inaccurate state label text and back callback enabled flag after rotation

Resolves #3575

PiperOrigin-RevId: 566433974
@dsn5ft
Copy link
Contributor

dsn5ft commented Sep 19, 2023

@manabu-nakamura can you file a separate issue for SearchView (and any others?)

This was referenced Sep 20, 2023
Closed
Closed
afohrman pushed a commit that referenced this issue Sep 21, 2023
@dsn5ft @afohrman
[Catalog][Predictive Back][Bottom Sheet] Update bottom sheet state ha…
386d47b 
…ndling to be more accurate in demos

Fixes inaccurate state label text and back callback enabled flag after rotation

Resolves #3573
Resolves #3575
Resolves #3577

Resolves #3574
Resolves #3576
Resolves #3578

PiperOrigin-RevId: 566286622
(cherry picked from commit f9102c7)
afohrman pushed a commit that referenced this issue Sep 21, 2023
@dsn5ft @afohrman
[Catalog][Predictive Back][Side Sheet] Update side sheet state handli…
4442635 
…ng to be more accurate in demos

Fixes inaccurate state label text and back callback enabled flag after rotation

Resolves #3575

PiperOrigin-RevId: 566433974
(cherry picked from commit 357cf2d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsn5ft dsn5ft

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsn5ft @manabu-nakamura