Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brotli cfile test #226

Closed
wants to merge 5 commits into from
Closed

Brotli cfile test #226

wants to merge 5 commits into from

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Oct 27, 2018

depends on #224 and #225

@stokito
Added test integrity for the cfile compressors: gzip, bzip2, etc. But…
63977ed 
… since most of them shows the message with file status to STDERR instead of STDOUT whe should show both in Test result window.
@lukefromdc lukefromdc requested a review from a team October 28, 2018 18:29
lukefromdc
lukefromdc reviewed Oct 29, 2018
View reviewed changes
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds, runs, and can both open and create .br files. The integrity test is not greyed out, but the results window comes up blank both with the provided test file (from the first of these PR's) and with one made myself using this version of Engrampa

@lukefromdc lukefromdc requested a review from a team October 29, 2018 21:03
@lukefromdc lukefromdc mentioned this pull request Oct 29, 2018
Merged
@stokito
Copy link
Contributor Author

stokito commented Oct 29, 2018

yes, that's because brotli really prints nothing to output and I created an issue about this
google/brotli#729

@stokito stokito mentioned this pull request Nov 1, 2018
Merged
@stokito
Copy link
Contributor Author

stokito commented Nov 2, 2018

I merged this patch into #225

@stokito stokito closed this Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukefromdc lukefromdc lukefromdc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stokito @lukefromdc