Add brotli support

[stokito]

Looks like my patch is working but if you can please review.
I almost made the same as bzip

[lukefromdc]

Can you provide a test file for that format? I have never seen it before

[stokito]

This is an algorithm developed in Google for compressing HTTP related data. Used in Android app store and supported almost by all browsers
https://caniuse.com/#feat=brotli

https://github.com/google/brotli
https://en.wikipedia.org/wiki/Brotli
sudo apt install brotli

[lukefromdc]

To test this in Engrampa we need to have a file compressed with it-or alternately if this provides the option to compress as well as decompress that would mostly test it but not prove that the compressed file was truly the same as those made by other programs.

[stokito]

sudo apt install brotli
brotli uptime.lsp

Result: https://stokito.com/uptime.lsp.br

[lukefromdc]

I can confirm this works for both compressing and extracting brotli files, both the provided test file and one I compressed myself. Caja does not yet recognize the brotli packages as archives, treating them as unknown filetype, so an update will be needed there as well but that's a separate issue.

Memory management looks to be unchanged with no new variables. This looks good to go

[stokito]

Caja does not yet recognize the brotli packages as archives, treating them as unknown file type.

I guess that's because brotli not yet recognized byfile command
google/brotli#727

Thank you for review.

[stokito]

Lines was changed so I regenerated it

On Tue, Oct 30, 2018 at 02:24 ZenWalker ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In help/engrampa.pot <#224 (comment)>: > @@ -1,7 +1,7 @@ msgid "" msgstr "" -"Project-Id-Version: MATE Desktop Environment\n" -"POT-Creation-Date: 2018-10-04 16:11+0200\n" +"Project-Id-Version: PACKAGE VERSION\n" +"POT-Creation-Date: 2018-10-27 19:39+0300\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" I think this file doesn't need changes — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#224 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZXDkckhQU1gCHwqhI-s4gjiuyXiBOdks5up5w_gaJpZM4X9iTq> .

-- Sergey Ponomarev <https://linkedin.com/in/stokito>, skype:stokito

[raveit65]

Please don't touch pot files. This we doing for ourself in an extra commit.

[stokito]

ok, sorry I didn't know. So, should I rollback the change of pot file?

…

On Tue, 30 Oct 2018 at 10:47, raveit65 ***@***.***> wrote: Please don't touch po files, we are using transifex server for translations. https://www.transifex.com/mate/MATE/dashboard/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#224 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZXDiUoW8TCBhl3GR25siGItIqx51c6ks5uqBIsgaJpZM4X9iTq> .

-- Sergey Ponomarev <https://linkedin.com/in/stokito>, skype:stokito

[raveit65]

Yes, please.
Are you familiar with using the git rebase -i <last-commit-before-your-PR> in you local repo?

There is a bug with creating pot files.

-"Project-Id-Version: MATE Desktop Environment\n"
+"Project-Id-Version: PACKAGE VERSION\n"

We always have to roll back this by hand.

[stokito]

ok, so I repushed the commit without pot files. Now can you marge it?

[sc0w]

I can open/compress files in that format with this PR.

@lukefromdc

Caja does not yet recognize the brotli packages as archives, treating them as unknown filetype, so an update will be needed there as well but that's a separate issue.

Yes, confirmed, I agree.