Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus styles for option controls #226

Closed
matatk opened this issue Dec 13, 2018 · 0 comments · Fixed by #327
Closed

Focus styles for option controls #226

matatk opened this issue Dec 13, 2018 · 0 comments · Fixed by #327
Assignees
Labels

Comments

@matatk
Copy link
Owner

matatk commented Dec 13, 2018

The <select>s don't have any focus indication; the others have quite weak focus indication. This should be provided by the browser but isn't (Chrome provides some, though it's not massively thick), so does need to be addressed.

(Testing this has reminded me that a separate options page is a very good idea, as it could be made easier to reach for keyboard-only users. Maybe a good idea to switch to that soon. Further: originally I was thinking the user should use the in-built browser methods for opening the options page, but given the Firefox macOS full-screen mode bug, and the fact that it would be easy to add options and help buttons to the pop-up when it's using a tree (as it'd only be a couple of tab stops to get to them), plus it's quite a lot of steps to reach the options in any browser, that too is sounding like a good idea.)

@matatk matatk added the bug label Dec 13, 2018
@matatk matatk added this to the 2.4.x milestone Dec 13, 2018
@matatk matatk self-assigned this Dec 13, 2018
@matatk matatk removed this from the 2.4.x milestone Dec 14, 2018
@matatk matatk added this to the 2.6.0 milestone Dec 29, 2018
matatk added a commit that referenced this issue Feb 2, 2020
* Move to a stand-alone options page on all browsers (taking some inspiration from  #157).
* Streamline the content of the Help page.
* Streamline styles.

Closes #227. Fixes #288. Closes #226.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant