Features/inaccurate error message execution controller #4777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xecution (#4710) * Requery bytecode * cargo fmt
* Improve async message checks * Change checks for async messages * Add unit tests
…ge (#4715) * Take again the speculative changes after async message cancellation * use .apply() to merge the two LedgerChanges * Fix: we cannot combine two ledger changes with apply * avoid cloning the changes * Remove comment
* fix open rpc spec (#4716) * Add eliminated_new_messages in eliminated_msg --------- Co-authored-by: Modship <[email protected]>
* Asc message execution - requery message bytecode after each message execution (#4710) * Requery bytecode * cargo fmt * fix call stack inconsistency (#4709) * Improve async message checks (#4706) * Improve async message checks * Change checks for async messages * Add unit tests * Fix ledger change to take into account cancelled message balance change (#4715) * Take again the speculative changes after async message cancellation * use .apply() to merge the two LedgerChanges * Fix: we cannot combine two ledger changes with apply * avoid cloning the changes * Remove comment * Fix async msg same slot (#4718) * fix open rpc spec (#4716) * Add eliminated_new_messages in eliminated_msg --------- Co-authored-by: Modship <[email protected]> * Consistent expiry period for async message and block operations * Update message validity for expiration * Minor comment fix --------- Co-authored-by: Leo-Besancon <[email protected]> Co-authored-by: Modship <[email protected]>
* fix fees * Update test_rewards execution test * Update test with updated reward formula * Update ci.yml * revert test change * Rm dbg and create const value * fmt --------- Co-authored-by: Leo-Besancon <[email protected]>
* Fix amount_remaining_to_slash_2 calculation * Rename slashed_coins and calculation to improve readability * Fix total_slashed_coins to return value
* Fix bad LedgerChanges::Delete handling * Avoid too much code duplication * Update ledger_db.rs * Fix check
* Use CondomLimits struct * Apply limits to wasm modules * Add max_runtime_module_exports * update runtime and serde_yaml * Fix outdated UT --------- Co-authored-by: Leo-Besancon <[email protected]> Co-authored-by: Jean-François <[email protected]> Signed-off-by: Jean-François <[email protected]>
* Update rust version to 1.81 * Cargo clippy & fmt pass * Cargo clippy & fmt pass 2 * Cargo clippy & fmt pass 3 * Remove commented code
* Update actions/checkout to v4 * Use dtolnay rust action instead of deprecated action-rs * Use dtolnay rust action (2) * Use dtolnay rust action (3) * Update JamesIves action for ci doc
* Add typos config file * Fix typo errors * Add typos to github CI * Cargo fmt pass * More typo fixes
* Fix SlotIndexPosition from Future to Past in case slots_since returns an error * Update ci.yml
…nciations (#4735) * Improve handling of HistorySearchResult * Fix CI
* Update ASC trigger comment * Add comment for ledger entry deletions * fmt
…4744) * Fix join error message (was inconsistent with: VM controller thread) * Cargo fmt pass
* Update tonic to version 0.12.3 and jsonrpsee to 0.24 * Cargo fmt pass * Test compilation fixes * Set prost as a workspace dependency (will be easier to later upgrade * Fix massa-api tests * Cargo fmt pass * Update jsonrpsee to 0.24.6 * Remove mut for builder * Move dev local dependencies (commented) * Change massa-sc-runtime & massa-proto-rs branches
* Add missing default gas cost for some abis * Add xtask check gas cost definitions * Update massa-sc-runtime in Cargo.lock * Update massa-sc-runtime in Cargo.lock - round 2 * Add eclude list in xtask check_gas_cost_definitions * Cargo fmt pass
…4762) * Add additional verification for v & s value in evm_signature_verify * Cargo fmt pass * Add additional verification for v & s value in evm_get_pubkey_from_signature * Cargo fmt pass * Isolate some tests * Cargo clippy fixes * Reject signature if signature.s is high order
#4763) * Remove wasm_gas_costs.json and used a constant value for wasm operator * Cargo fmt pass * Update massa-sc-runtime dependency
* Asc message execution - requery message bytecode after each message execution (#4710) * Requery bytecode * cargo fmt * fix call stack inconsistency (#4709) * Improve async message checks (#4706) * Improve async message checks * Change checks for async messages * Add unit tests * Fix ledger change to take into account cancelled message balance change (#4715) * Take again the speculative changes after async message cancellation * use .apply() to merge the two LedgerChanges * Fix: we cannot combine two ledger changes with apply * avoid cloning the changes * Remove comment * Fix async msg same slot (#4718) * fix open rpc spec (#4716) * Add eliminated_new_messages in eliminated_msg --------- Co-authored-by: Modship <[email protected]> * Add initial code for recursion limit * Latest runtime * Run CI on PRs based on mainnet_2_3 * fmt * Fix config and add UTs * Update scenarios_mandatories.rs * Review comments (CI for all branches starting with "mainnet_" + comment) * Update ci.yml * Remove manual increment / decrement in interface implementation * fmt + update sc_runtime + fix warning * Update test * Update constants.rs * Updated execution config for tests * Updated usize -> u16 for recursion counter and limits * Update test comments * Add comments regarding the needs of this limits * Update sc-runtime branch --------- Co-authored-by: Modship <[email protected]>
* Update executed denunciations in StateChanges.apply method * Cargo fmt pass
* Limit event msg size & event number per operation * Fix typo * Add unit tests for event data size & count * Cargo fmt * Cargo clippy fices * Create event after all checks * Cargo fmt * Create event before using it
* Delete bootstrap_whitelist.json * Add bootstrap_whitelist file for tests * Use TempFile instead of hardcoded whitelist test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.