New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix address categorization in wasmv1 ABI #4728

Merged

Leo-Besancon merged 1 commit into mainnet_2_3 from fix_address_category_mapping

Jul 16, 2024

Collaborator

Leo-Besancon commented Jul 15, 2024

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification


          Update interface_impl.rs

8b6ec72

Leo-Besancon changed the title ~~Update interface_impl.rs~~ Fix address categorization in wasmv1 ABI

Leo-Besancon requested review from sydhds and modship

July 15, 2024 13:57

modship approved these changes

View reviewed changes

Leo-Besancon merged commit a44a2da into mainnet_2_3

Leo-Besancon added a commit that referenced this pull request


          Update interface_impl.rs (#4728)

aa7efcf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet