Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in local Euclidean distance calculation for fast implementation #41

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

masadcv
Copy link
Owner

@masadcv masadcv commented Feb 20, 2023

As reported in #40 , the only Euclidean case appeared to be computing taxicab distance.

On closer look, it came down to bug in local distance calculation

This PR attempts to fix this.

@masadcv
Copy link
Owner Author

masadcv commented Feb 20, 2023

Using the code from #40 with modification to add GeodisTK results, here is comparison of 3d Euclidean distance with the bug:
fig

And here are results with fixes from this PR:
figa

With the PR, the Euclidean distances improve and is in-line with Euclidean distance from previous raster scan methods (e.g. using GeodisTK). It, however, is an approximation and unavoidable artifacts are present which are due reliance of these methods on iterative raster scans for distance transform computation

@masadcv masadcv merged commit 7101eb3 into master Feb 20, 2023
@masadcv masadcv deleted the euclidean-impl branch February 20, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant