Remove inlineSVG workaround option #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest chrome 67 is fixed a major rendering bug caused by parent style. `workaround` option will disable the important declaration `position: relative;`, so it does not work with `paginate` directive correctly.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove
workaroundflag ininlineSVGoption. The latest chrome 67 has fixed a major rendering bug caused by style.workaroundoption will disable the important declarationposition, so it does not work withpaginatedirective correctly.Remaining bugs
The minor rendering bugs on Chrome are not yet resolved. In Mac, A
<foreignObject>will render with the original size if an auto-scaled slide did overflow from a container element. Curiously we cannot reproduce this in Windows.Fortunately we can avoid this problem by changing DOM structure of the parent elements. (Use
bodyinstead ofoverflow: autocontainer)