Fix incorrect SVG scaling on Chrome #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UPDATE: It seems that this issue will be fixed if Chrome instance is executed with --enable-blink-gen-property-trees option (#33). translateZ hack might still cause the glitch at remaining space in scaled slide. We would remove these hacks if Chrome became to generate property trees by default. Until then we have to choice between to allow glitch on Chrome or to force enabling Chrome option. Marp CLI should select the former because the HTML output cannot select environment of browser. |
This was referenced Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slide-deck outputted with bare template would not scaled-down correctly if you are opening it in Mac's Chrome. This problem had been a headache continued from marp-team/marpit#35 over 3 months.
We found a bit hacky workaround that use
transformstyle. This PR would applytransform: translateZ(0);to SVG element of each template.