Add mathjax support #165
Closed
Add mathjax support #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2020 00:41
Closed
yhatt
reviewed
Jun 6, 2020
| @@ -25,6 +26,7 @@ export interface MarpOptions extends Options { | |||
| | { [attr: string]: boolean | ((value: string) => string) } | |||
| } | |||
| markdown?: object | |||
| mathjax?: boolean | |||
There was a problem hiding this comment.
I think that interface of constructor option is not intuitive. math: 'mathjax' would be better than an individual option.
There was a problem hiding this comment.
Nice idea. Let me confirm you.
math: 'katex' # enable katex as same as `true`
math: true # enable katex for backward compatibility
math: { ... } # enable katex with options
math: 'mathjax' # enable mathjax
Do you want to do like this?
|
|
||
| try { | ||
| return `<p>${adaptor.outerHTML( | ||
| mathDocument.convert(content, genOpts(true)) |
There was a problem hiding this comment.
By comparing to KaTeX rendering, the rendered math block is not centering.
There was a problem hiding this comment.
Solved, check it.
const { Marp } = require("./lib/marp.js")
const marp = new Marp({ math: true, mathjax: false})
const md = `
# Elementary Math
$$
1+1 = 2
$$
`
const r = marp.render(md)
console.log(r.html + `<style>${r.css}</style>`)
|
My updates have been done by #166 . Thus, I stop to update this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164