Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathJaX v3 support #164

Closed
tani opened this issue Jun 6, 2020 · 4 comments · Fixed by #166
Closed

MathJaX v3 support #164

tani opened this issue Jun 6, 2020 · 4 comments · Fixed by #166
Labels
enhancement New feature or request

Comments

@tani
Copy link

tani commented Jun 6, 2020

Hi there, I am author of the following plugins

As I'd like to use MathJaX v3 in map-core, I open this issue. MathJaX v3 has a new plugin for bussproofs missing in the older versions, and also, has a SVG rendering without any fonts. There is good conformance for your project at the SVG feature.

I've already implemented markdown-it plugin with TypeScript based on markdown-it-katex as like marp-core. Thus, I can add MathJaX plugin to your project immediately.

I'd like to ask you, which options do you choose?

  1. Replacing KaTeX plugin with MathJaX plugin
  2. Adding MathJaX plugin, and keeping KaTeX plugin

Thanks!

@yhatt yhatt added the enhancement New feature or request label Jun 6, 2020
@yhatt
Copy link
Member

yhatt commented Jun 6, 2020

Thanks for your suggestion. Due to slow rendering and not supported server-side rendering, we had given up using MathJax v2 in Marp. But MathJax v3 seems to have got rid of many messy issues.

And we had some requests about math typesettings, such as yhatt/marp#103 and yhatt/marp#181. They are not yet resolved by KaTeX's limitations and might be fix them by MathJax v3 integration.

I prefer option 2 to make compatibility with exist decks made with KaTeX for now.

@tani
Copy link
Author

tani commented Jun 6, 2020

Okay, check my pull request #165 . I've implemented option 2 because I also thought as you 😉

@yhatt
Copy link
Member

yhatt commented Jun 6, 2020

NOTE: Keep in mind that we require to support auto-scaling in math block when you will work for Marp Core integration.

@tani
Copy link
Author

tani commented Jun 6, 2020

At least, all tests are passed including a new test I added for auto-scaling in math block.
I just borrow all test code from your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants