Output warning if detected blocking local resources while rendering by Chrome #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Marp CLI outputs warning if failed the request of file scheme. (powered by Puppeteer's
requestfailedevent)User can see this warning when using local files in Markdown conversion to PDF and images. It would help user to notice requiring uploaded assets, or lacked
--allow-local-filesoption to render local files.It requires the update of
hrefattr ofbasetag: Addfile:scheme, to fallback a relative path indata:scheme HTML tofile:scheme and catch request errors by Puppeteer correctly.Fixes #84.