Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output warning if detected blocking local resources while rendering by Chrome #84

Closed
yhatt opened this issue Apr 11, 2019 · 1 comment · Fixed by #98
Closed

Output warning if detected blocking local resources while rendering by Chrome #84

yhatt opened this issue Apr 11, 2019 · 1 comment · Fixed by #98
Labels
enhancement New feature or request

Comments

@yhatt
Copy link
Member

yhatt commented Apr 11, 2019

I've received many feedbacks about rendering the local image file, "Image does not see on rendered PDF". In most cases, a cause is lacking --allow-local-files option.

Accessing the local content is often targeted as a vulnerability, so the user must express intention by the option. However, Marp CLI has not explained this while converting.

It's good to tell that it might lack --allow-local-files option if detected blocking access to the local file. Of course, we should keep in mind that it's just a hint and must keep not to recommend.

How to detect

We don't yet try for detection, but I wonder if Chrome outputs any warnings with its reason when blocked loading image. We should listen to Chrome error through Puppeteer, and detect local file access.

@yhatt
Copy link
Member Author

yhatt commented May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant