Build standalone executable binaries by pkg (experimental) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default path of carlo is not suitable to standalone build.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add build script to create standalone executable binaries by using pkg. It is based on feedback to yhatt/marp#13 (comment).
Marp CLI have already provided Docker image to user not wanted to install Node and Chrome / Chromium. However, it can not win against the standalone binary that is required no dependent tools.
Though the compiled binary by pkg seems working very well, I'm afraid to the difference of behavior caused from pkg's snapshot filesystem. (e.g. Carlo is not working in default setting. This PR includes fix to use tmp directory as a profile directory for Carlo). Thus, we mark binaries as experimental.
We are going to work for automation uploading binaries to Github release in another PR.