Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Puppeteer to v8 #329

Merged
merged 4 commits into from
Mar 13, 2021
Merged

Upgrade Puppeteer to v8 #329

merged 4 commits into from
Mar 13, 2021

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Mar 13, 2021

Bumped Puppeteer to v8.

Notable changes

  • Followed up updated TypeScript definitions.
  • Fix how to take screenshots that had affected by Puppeteer v7 breaking changes.
    • Set clip option to specifty clipping region of the page.
    • Left window.scrollTo() for keeping to support outdated Chrome <= 88. The scroll position of page has not affected to clip option for Chrome >= 89.

Fix #325.

@yhatt yhatt merged commit 3283ce0 into main Mar 13, 2021
@yhatt yhatt deleted the puppeteer-v8 branch March 13, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion into multi images/PPTX takes only the first slide if using Chromium >= v89
1 participant