-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion into multi images/PPTX takes only the first slide if using Chromium >= v89 #325
Comments
I've confirmed this bug in Chromium r843427, the current stable Chrome 89 (for Puppeteer >= v6.0.0). It can fix by simply following Puppeteer's breaking change: Remove However, screenshots may break in a previous Chrome 88 (Chromium r818858 / Puppeteer v5.5.0) if took screenshots with |
Originally reported in marp-team/marp-vscode#202.
Marp CLI has updated Puppeteer to v7.x in #319. It has a breaking change for
page.screenshot()
. Marp CLI uses this for taking a image of slides while multi-image conversion and PPTX conversion.We have taken screenshots by scrolling contents with fixed viewport position, but this change means that way is no longer working in the latest Chromium.
marp-cli/src/converter.ts
Lines 260 to 278 in 1ffcdf5
If trying to take screenshots through the latest Google Chrome Canary (>= v90), every slide pages will have only the first slide.
The text was updated successfully, but these errors were encountered: