Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presenter view to Bespoke template #157

Merged
merged 26 commits into from
Jan 18, 2020
Merged

Add presenter view to Bespoke template #157

merged 26 commits into from
Jan 18, 2020

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Sep 18, 2019

Add presenter view to Bespoke template by created Bespoke.js presenter plugin. Resolves #142.

presenter-view

Now we have the long-awaited feature! Presenter view for Marp presentation had strongly wanted in yhatt/marp#13 and yhatt/marp#30 from a lot of users.

It works with just a single HTML file in both of local and server. Thus, this feature does not break simplicity as a file converter.

@miguel-negrao
Copy link

I can report this branch works great on Linux Debian 10 with firefox 69.0 ! Really nice feature !

@asm0dey
Copy link

asm0dey commented Jan 3, 2020

If this works fine — is there any chance that it will be merged in nearest future?

@asm0dey
Copy link

asm0dey commented Jan 3, 2020

BTW works for like a charm after merging master into bespoke-presenter.

@yhatt
Copy link
Member Author

yhatt commented Jan 6, 2020

This PR is still draft because of these:

  • Timer is not yet work.
  • We must fill tests for aiming to all green.

However, I've hesitated working because current plugin-based presenter view is feeling complex and lacked maintainability (As mentioned in our blog, Marp Next should keep simple coding for better maintainability).

Even so, I also could not think about better alternative proposal with supporting full features of HTML-based presentation provided by Marp / Marpit (Fragmented list, animations by CSS/GIF, interactivities by JS etc...). I'll work for this if contributors think this implementation was not so bad.

@asm0dey

This comment has been minimized.

@asm0dey

This comment has been minimized.

@yhatt

This comment has been minimized.

@asm0dey

This comment has been minimized.

@yhatt

This comment has been minimized.

@asm0dey

This comment has been minimized.

@asm0dey

This comment has been minimized.

@yhatt yhatt marked this pull request as ready for review January 18, 2020 10:21
@yhatt yhatt merged commit e6078c1 into master Jan 18, 2020
@yhatt yhatt deleted the bespoke-presenter branch January 18, 2020 10:31
@asm0dey
Copy link

asm0dey commented Jan 18, 2020

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presenter view for HTML
3 participants