Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Windows environment + updated globby v10 (#109), files cannot find from the passed directory. This PR fixes it and improve the stability of tests.
File.findPath
for converting and normalizing between glob pattern and real path.app.exit()
of Carlo in Windows. We do no longer use theterminate
module to kill the remaining process. (But it's still unstable to handle Chrome process while testing)The best way to prevent new release included bugs is to add the Windows test environment in CI. CircleCI is not supported Windows, but there is a pre-release for preview now.