Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone build for Windows raises segfault error since v0.9.3 #111

Closed
yhatt opened this issue Jun 26, 2019 · 2 comments · Fixed by #112
Closed

Standalone build for Windows raises segfault error since v0.9.3 #111

yhatt opened this issue Jun 26, 2019 · 2 comments · Fixed by #112

Comments

@yhatt
Copy link
Member

yhatt commented Jun 26, 2019

Since pkg v4.4.0 updated in #99, automated standalone build in CI has invalid binary for Windows with segfault error.

vercel/pkg#710
@yhatt
Copy link
Member Author

yhatt commented Jun 26, 2019

As a workaround, I updated packages in release page to new package built in local Windows environment.

We should downgrade pkg to v4.3.7.

yhatt added a commit that referenced this issue Jun 27, 2019
@yhatt
Downgrade pkg to v4.3.8
410c113 
Automated build of standalone binary for Windows raises segfault in the
latest pkg. Resolves #111.
@yhatt
Copy link
Member Author

yhatt commented Jun 27, 2019

Automated standalone build for Windows with downgraded pkg is here:
https://1640-144130157-gh.circle-artifacts.com/0/dist/marp-cli-v0.10.2-win.zip

I'll be back to check it in my Windows...

@yhatt yhatt mentioned this issue Jun 27, 2019
Merged
@yhatt yhatt mentioned this issue Jun 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Downgrade pkg to v4.3.x to fix segfault in the standalone build for Windows marp-team/marp-cli
1 participant
@yhatt