Upgrade Marp Core to v0.10.2 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
commented
Jun 21, 2019
package.json
Outdated
| @@ -133,7 +133,7 @@ | |||
| "os-locale": "^4.0.0", | |||
| "pkg-up": "^3.1.0", | |||
| "portfinder": "^1.0.20", | |||
| "puppeteer-core": "^1.17.0", | |||
| "puppeteer-core": "^1.18.0", | |||
There was a problem hiding this comment.
Puppeteer v1.18.0 has an updated protocol to create PDF. It will be supported from Chromium 77, and we cannot use for the current stable Chrome (75). Thus, we should stop to update minor version of Puppeteer for a while.
yhatt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will upgrade
dependent package versionsMarp Core to the latest version byyarn upgrade --latest.It only includes the update of Marp Core v0.10.2 and can reduce file size of the converted HTML.
We are going to publish new patch version as soon as if have confirmed the result of CI.