Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Fix error messages on failed deletes, updates #1197

Merged
merged 1 commit into from
Oct 11, 2016
Merged

[RFR] Fix error messages on failed deletes, updates #1197

merged 1 commit into from
Oct 11, 2016

Conversation

jpetitcolas
Copy link
Contributor

No description provided.

@jpetitcolas
Copy link
Contributor Author

jpetitcolas commented Sep 19, 2016 •
edited
Loading

Closes #1130.

@RichardBradley
Copy link
Contributor

(It doesn't close all of #1129, just makes it better. See comments on #1130)

@Phocea
Copy link
Contributor

Phocea commented Oct 11, 2016

@jpetitcolas do you have an ETA on this merge by any chance ?

@jpetitcolas jpetitcolas merged commit c4ab78d into master Oct 11, 2016
@jpetitcolas jpetitcolas deleted the error_message_on_failed_delete branch October 11, 2016 15:10
@jpetitcolas
Copy link
Contributor Author

@Phocea: a few seconds ago. :)

@Phocea
Copy link
Contributor

Phocea commented Oct 12, 2016

works a treat, much better.
Do you think this one could also be merged #1223 so we also get the error message displayed correctly when happening on state change?

Will open another PR later with a way to configure the redirect depending on the http code error

@Phocea Phocea mentioned this pull request Oct 12, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpetitcolas @RichardBradley @Phocea